From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v1 0/3] Add missing ethdev driver support Date: Tue, 16 Feb 2016 10:54:52 -0800 Message-ID: <20160216105452.0b1da99f@xeon-e3> References: <1453970895-2639-1-git-send-email-remy.horton@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 4FE732A5E for ; Tue, 16 Feb 2016 19:54:41 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id ho8so109243596pac.2 for ; Tue, 16 Feb 2016 10:54:41 -0800 (PST) In-Reply-To: <1453970895-2639-1-git-send-email-remy.horton@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 28 Jan 2016 08:48:12 +0000 Remy Horton wrote: > Several rte_eth_dev_* functions are currently only supported > by the ixgbe NIC driver. This patchset adds driver support > for some of these functions to the i40e, virtio, and vmxnet3 > drivers. It is good to make drivers more complete and compatible, but unless the virtual driver has some useful data I can't see the point of providing these functions in this case. The base infrastructure (rte_ethdev) should deal with by returning not supported error (or all zeros); rather than creating more code in other drivers for no real gain.