From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: close fd's in parent when spawning qdisk
Date: Tue, 16 Feb 2016 12:59:54 +0000 [thread overview]
Message-ID: <20160216125954.GN10489@citrix.com> (raw)
In-Reply-To: <1455623393-17364-1-git-send-email-ian.campbell@citrix.com>
On Tue, Feb 16, 2016 at 11:49:53AM +0000, Ian Campbell wrote:
> Coverity points out that these remain open in the parent upon
> success, which is a resource leak.
>
> To fix this rejig the exit paths such that success and error cases
> both close the two fds, this means adjusting the callback to only
> happen for the error case and it also makes sense to rename the label
> from "error" to just "out".
>
> Compile tested only.
>
> CID: 1130518 (null) and 1130517 (logfile_w).
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
next prev parent reply other threads:[~2016-02-16 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 11:49 [PATCH] libxl: close fd's in parent when spawning qdisk Ian Campbell
2016-02-16 12:59 ` Wei Liu [this message]
2016-02-16 17:43 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216125954.GN10489@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.