From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755240AbcBPOoF (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 09:44:05 -0500
Received: from mx2.suse.de ([195.135.220.15]:36414 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751221AbcBPOoD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 09:44:03 -0500
Date: Tue, 16 Feb 2016 15:44:02 +0100
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.com>,
        Tejun Heo <tj@kernel.org>, Kyle McMartin <kyle@kernel.org>,
        Dave Jones <davej@codemonkey.org.uk>,
        Calvin Owens <calvinowens@fb.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v4 3/3] printk: check CON_ENABLED in
 have_callable_console()
Message-ID: <20160216144402.GV12548@pathway.suse.cz>
References: <1455302232-2252-1-git-send-email-sergey.senozhatsky@gmail.com>
 <1455302232-2252-4-git-send-email-sergey.senozhatsky@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455302232-2252-4-git-send-email-sergey.senozhatsky@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat 2016-02-13 03:37:12, Sergey Senozhatsky wrote:
> have_callable_console() must also test CON_ENABLED bit, not just
> CON_ANYTIME. We may have disabled CON_ANYTIME console so printk
> can wrongly assume that it's safe to call_console_drivers().
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Makes perfect sense.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr