From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v8 3/5] libxl: add support for vscsi Date: Tue, 16 Feb 2016 16:23:47 +0100 Message-ID: <20160216152347.GA31209@aepfle.de> References: <1455205411-25460-1-git-send-email-olaf@aepfle.de> <1455205411-25460-4-git-send-email-olaf@aepfle.de> <20160212172748.GA8818@citrix.com> <20160212182459.GA28852@aepfle.de> <20160215151610.GC10489@citrix.com> <22210.1606.505673.813453@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <22210.1606.505673.813453@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Stefano Stabellini , Wei Liu , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, Ian Jackson wrote: > One reason you might define a virtual controller with no devices yet > is so that you have a stable and pre-expected device path for any > actual targets you choose to hotplug later. Would it be acceptable to reuse the devid as the "group index"? The various vdev in vscsi=['pdev,vdev'] will be assigned to the same vscsictrl if the host part in host:chn:target:lun matches. Right now an empty vscsictrl has no property to store the "host" part. This could be handled by either reusing devid, or by introducing a new xenstore property such as "libxl_vscsictrl_index". The value itself has no meaning other than being an index or label. Olaf