From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 1/2] iommu: call detach also for default_domain before attaching to new one
Date: Tue, 16 Feb 2016 16:59:22 +0100 [thread overview]
Message-ID: <20160216155922.GV18805@8bytes.org> (raw)
In-Reply-To: <1455633632-16873-2-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Tue, Feb 16, 2016 at 03:40:31PM +0100, Marek Szyprowski wrote:
> This patch ensures that devices attached to the default_domain will be
> first detached from it before attaching to new domain. To avoid forward
> declaration, __iommu_attach_group() function has been moved to new place
> in the source code.
Actually it was intentional to not invoke the detach_device call-back in
the attach_device path.
The reason is that detaching first and than attaching again leaves the
device without a domain for a short period of time, until it is attached
to the new domain.
The attach_device call-back is supposed to handle this situation and
just silently overwrite any other domain->device binding it finds for
the device.
This allows to do re-attachment with less iommu flushes and to get rid
of the detach_device call-back at some point.
Joerg
next prev parent reply other threads:[~2016-02-16 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 14:40 [PATCH 0/2] iommu: fix handling of attach/detach for default domains Marek Szyprowski
[not found] ` <1455633632-16873-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-16 14:40 ` [PATCH 1/2] iommu: call detach also for default_domain before attaching to new one Marek Szyprowski
[not found] ` <1455633632-16873-2-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-16 15:59 ` Joerg Roedel [this message]
[not found] ` <20160216155922.GV18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-02-17 7:35 ` Marek Szyprowski
[not found] ` <56C422AE.9000108-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-17 11:14 ` Joerg Roedel
[not found] ` <20160217111450.GA18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-02-17 14:42 ` Marek Szyprowski
[not found] ` <56C486EE.5020504-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-25 14:01 ` Joerg Roedel
2016-02-16 14:40 ` [PATCH 2/2] iommu: fix default domain handling in __iommu_detach_group() Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216155922.GV18805@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.