From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, eranian@google.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/8] perf, tools, stat: Move noise/running printing into printout
Date: Tue, 16 Feb 2016 17:02:56 -0300 [thread overview]
Message-ID: <20160216200256.GI17690@kernel.org> (raw)
In-Reply-To: <1454173616-17710-4-git-send-email-andi@firstfloor.org>
Em Sat, Jan 30, 2016 at 09:06:51AM -0800, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> Move the running/noise printing into printout to avoid
> duplicated code in the callers.
>
> v2: Merged with other patches. Remove unnecessary hunk.
> Readd hunk that ended in earlier patch.
> v3: Fix noise/running output in CSV mode
> v4: Merge with later patch that also moves not supported printing.
> Acked-by: Jiri Olsa <jolsa@kernel.org>
So, the description makes it look like this is just elliminating code
duplication, but then, before we had:
[acme@jouet linux]$ perf.old stat -I 500 -e instructions,cycles sleep 1
# time counts unit events
0.500164711 548,376 instructions # 0.72 insn per cycle
0.500164711 756,872 cycles
1.000405470 <not counted> instructions
1.000405470 <not counted> cycles
1.000690913 156,623 instructions # 0.48 insn per cycle
1.000690913 226,630 cycles
[acme@jouet linux]$
And now we have instead:
[acme@jouet linux]$ perf stat -I 500 -e instructions,cycles sleep 1
# time counts unit events
0.500173751 555,962 instructions # 0.77 insn per cycle
0.500173751 722,964 cycles
1.000382613 0 instructions # 0.00 insn per cycle
1.000382613 0 cycles
1.001157068 154,765 instructions # 0.49 insn per cycle
1.001157068 223,609 cycles
[acme@jouet linux]$
So there is a change in behaviour.
- Arnaldo
next prev parent reply other threads:[~2016-02-16 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 17:06 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-30 17:06 ` [PATCH 1/8] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2016-02-16 19:33 ` Arnaldo Carvalho de Melo
2016-02-17 12:09 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-01-30 17:06 ` [PATCH 2/8] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2016-02-16 19:57 ` Arnaldo Carvalho de Melo
2016-02-17 12:09 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-01-30 17:06 ` [PATCH 3/8] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-02-16 20:02 ` Arnaldo Carvalho de Melo [this message]
2016-02-17 19:27 ` Andi Kleen
2016-02-17 12:10 ` [tip:perf/core] perf stat: Move noise/ running " tip-bot for Andi Kleen
2016-01-30 17:06 ` [PATCH 4/8] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-02-02 9:50 ` Jiri Olsa
2016-02-02 14:02 ` Andi Kleen
2016-01-30 17:06 ` [PATCH 5/8] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-01-30 17:06 ` [PATCH 6/8] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-01-30 17:06 ` [PATCH 7/8] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-01-30 17:06 ` [PATCH 8/8] perf, tools: Add --metric-only support for -A Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2016-01-27 0:42 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-27 0:42 ` [PATCH 3/8] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2016-01-28 9:49 ` Jiri Olsa
2016-01-16 1:11 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-01-16 1:11 ` [PATCH 3/8] perf, tools, stat: Move noise/running printing into printout Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216200256.GI17690@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.