From: Andrew Lunn <andrew@lunn.ch>
To: Bryan.Whitehead@microchip.com
Cc: f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver
Date: Tue, 16 Feb 2016 21:36:25 +0100 [thread overview]
Message-ID: <20160216203625.GC2558@lunn.ch> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D264402EFB12@CHN-SV-EXMX02.mchp-main.com>
On Tue, Feb 16, 2016 at 07:41:46PM +0000, Bryan.Whitehead@microchip.com wrote:
> Andrew,
>
> At this point, I am not tasked with implementing switch features,
> which would likely take a long time to complete.
So this is the discussion we need to have.
The interface to the outside work is the two switch ports with real
PHYs. What you are implementing is an Ethernet driver for an internal
port connected to the switch. This port does not go to the outside
world. This driver provides no way to control the ports to the outside
world and you have no short term plan to actually implement control of
the ports connected to the outside world.
Should the Linux community accept this driver in this state?
I would prefer to see a simple switchdev or DSA driver which exposes
the two external ports.
Andrew
next prev parent reply other threads:[~2016-02-16 20:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 18:58 [PATCH net-next,V2] Add LAN9352 Ethernet Driver Bryan.Whitehead
2016-02-11 21:55 ` Andrew Lunn
2016-02-12 16:51 ` Bryan.Whitehead
2016-02-12 17:11 ` Andrew Lunn
2016-02-16 19:34 ` Bryan.Whitehead
2016-02-16 19:51 ` David Miller
2016-02-16 20:21 ` Andrew Lunn
2016-02-12 0:14 ` Lino Sanfilippo
2016-02-12 19:10 ` Bryan.Whitehead
2016-02-16 22:09 ` Lino Sanfilippo
2016-02-12 2:18 ` Florian Fainelli
2016-02-12 7:20 ` Andrew Lunn
2016-02-12 16:53 ` Bryan.Whitehead
2016-02-12 17:18 ` Andrew Lunn
2016-02-16 19:41 ` Bryan.Whitehead
2016-02-16 19:52 ` David Miller
2016-02-16 20:36 ` Andrew Lunn [this message]
2016-02-16 20:43 ` David Miller
2016-02-16 20:48 ` Bryan.Whitehead
2016-02-16 20:52 ` David Miller
2016-02-16 21:32 ` Bryan.Whitehead
2016-02-16 21:38 ` David Miller
2016-02-16 22:15 ` Andrew Lunn
2016-02-17 0:06 ` Florian Fainelli
2016-02-17 0:31 ` Andrew Lunn
2016-02-19 19:29 ` Bryan.Whitehead
2016-02-19 20:14 ` Andrew Lunn
2016-02-19 21:21 ` Bryan.Whitehead
2016-03-24 21:16 ` Bryan.Whitehead
2016-03-24 22:06 ` Andrew Lunn
2016-03-24 22:36 ` Florian Fainelli
2016-02-16 20:57 ` Andrew Lunn
2016-02-16 21:37 ` Bryan.Whitehead
2016-02-16 21:40 ` David Miller
2016-02-12 23:21 ` Bryan.Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216203625.GC2558@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.