All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Declare SED Makefile instead of package/Makefile.in so it exists globally.
Date: Tue, 16 Feb 2016 21:35:54 +0100	[thread overview]
Message-ID: <20160216213554.60f53246@free-electrons.com> (raw)
In-Reply-To: <1455635726-22028-1-git-send-email-alvaro.gamez@hazent.com>

Hello,

The title is too long, it should be:

	Makefile: declare SED globally

or something like that.

On Tue, 16 Feb 2016 16:15:26 +0100, Alvaro G. M wrote:
> In particular, this allows the use of buildroot-submodule and in general,
> any use of buildroot from out of tree.

This commit log should be improved, because:

 1/ Why should we care about buildroot-submodule, and if we care, what
    is the actual problem ?

 2/ What do you mean by "use Buildroot from out of tree" ? I do out of
    tree builds every day and it works just fine. So this aspect needs
    to be detailed.

I have nothing against the change, which is fairly simple, but it needs
to be justified properly.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-16 20:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 10:26 [Buildroot] $(SED) not defined if 'make menuconfig savedefconfig' Alvaro Gamez
2015-06-15 13:37 ` Thomas Petazzoni
2015-06-15 14:20   ` rdkehn at yahoo.com
2015-06-16  7:58     ` Alvaro Gamez
2016-02-16 11:46       ` Alvaro Gamez
2016-02-16 15:10         ` Thomas Petazzoni
2016-02-16 15:15           ` [Buildroot] [PATCH 1/1] Declare SED Makefile instead of package/Makefile.in so it exists globally Alvaro G. M
2016-02-16 20:35             ` Thomas Petazzoni [this message]
2016-02-16 22:35               ` Arnout Vandecappelle
2016-02-17  8:22                 ` Alvaro Gamez
2016-02-17  8:47                   ` Thomas Petazzoni
2016-02-27 13:17                     ` Arnout Vandecappelle
2016-02-27 22:00                       ` Peter Korsgaard
2016-02-28  7:43                         ` Alvaro Gamez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160216213554.60f53246@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.