From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755794AbcBQCdN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 21:33:13 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:59285 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752853AbcBQCdM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 21:33:12 -0500
Date: Wed, 17 Feb 2016 02:33:10 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/7] drivers: char: mem: fix IS_ERROR_VALUE usage
Message-ID: <20160217023310.GH17997@ZenIV.linux.org.uk>
References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com>
 <1455546925-22119-4-git-send-email-a.hajda@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455546925-22119-4-git-send-email-a.hajda@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 15, 2016 at 03:35:21PM +0100, Andrzej Hajda wrote:
> diff --git a/drivers/char/mem.c b/drivers/char/mem.c
> index 4f6f94c..71025c2 100644
> --- a/drivers/char/mem.c
> +++ b/drivers/char/mem.c
> @@ -695,7 +695,7 @@ static loff_t memory_lseek(struct file *file, loff_t offset, int orig)
>  		offset += file->f_pos;
>  	case SEEK_SET:
>  		/* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */
> -		if (IS_ERR_VALUE((unsigned long long)offset)) {
> +		if ((unsigned long long)offset >= -MAX_ERRNO) {
>  			ret = -EOVERFLOW;
>  			break;
>  		}

ACK