Re: [Outreachy kernel] [PATCH v2 2/7] staging: netlogic: Remove blank spaces after a cast

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Tue, Feb 16, 2016 at 11:36:31PM +0100, Laura Garcia Liebana wrote:
> Remove uneeded blank spaces after a cast. Checkpatch found these issues.
> 
> Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
> ---
> v2: Include parentheses for pointers, as Julia suggested
> 
>  drivers/staging/netlogic/xlr_net.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 59fbaba..b89e3cb 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -130,13 +130,13 @@ static void xlr_net_fmn_handler(int bkt, int src_stnid, int size, int code,
>  	struct xlr_net_priv *priv;
>  	u32 port, length;
>  	unsigned char *addr;
> -	struct xlr_adapter *adapter = (struct xlr_adapter *) arg;
> +	struct xlr_adapter *adapter = (struct xlr_adapter *)arg;
>  
>  	length = (msg->msg0 >> 40) & 0x3fff;
>  	if (length == 0) {
>  		addr = bus_to_virt(msg->msg0 & 0xffffffffffULL);
>  		addr = addr - MAC_SKB_BACK_PTR_SIZE;
> -		skb = (struct sk_buff *) *(unsigned long *)addr;
> +		skb = (struct sk_buff *)(*)(unsigned long *)addr;

I think a better choice might have been:
	skb = (struct sk_buff *)(*(unsigned long *)addr);

regards
sudip