From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 17 Feb 2016 09:02:35 +0100 From: Ingo Molnar Subject: Re: [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache() Message-ID: <20160217080235.GA20160@gmail.com> References: <1455225857-12039-1-git-send-email-toshi.kani@hpe.com> <1455225857-12039-2-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455225857-12039-2-git-send-email-toshi.kani@hpe.com> Sender: linux-kernel-owner@vger.kernel.org To: Toshi Kani Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, dan.j.williams@intel.com, ross.zwisler@linux.intel.com, vishal.l.verma@intel.com, micah.parrish@hpe.com, brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org List-ID: * Toshi Kani wrote: > Add comments to __copy_user_nocache() to clarify its procedures > and alignment requirement. > > Also change numeric branch target labels to named labels. The > labels begin with ".L" and prefix "cun" (Copy User Nocache) to > keep them local and unique to the function. So the .L labels are local, i.e. they are not emitted into the symbol table. I.e. no need to name them globally! I've done a s/Lcun_/L_/ over the patch. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756831AbcBQICl (ORCPT ); Wed, 17 Feb 2016 03:02:41 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38178 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756782AbcBQICk (ORCPT ); Wed, 17 Feb 2016 03:02:40 -0500 Date: Wed, 17 Feb 2016 09:02:35 +0100 From: Ingo Molnar To: Toshi Kani Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, dan.j.williams@intel.com, ross.zwisler@linux.intel.com, vishal.l.verma@intel.com, micah.parrish@hpe.com, brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache() Message-ID: <20160217080235.GA20160@gmail.com> References: <1455225857-12039-1-git-send-email-toshi.kani@hpe.com> <1455225857-12039-2-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455225857-12039-2-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Toshi Kani wrote: > Add comments to __copy_user_nocache() to clarify its procedures > and alignment requirement. > > Also change numeric branch target labels to named labels. The > labels begin with ".L" and prefix "cun" (Copy User Nocache) to > keep them local and unique to the function. So the .L labels are local, i.e. they are not emitted into the symbol table. I.e. no need to name them globally! I've done a s/Lcun_/L_/ over the patch. Thanks, Ingo