All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/iputils: patch ping to link against libm
Date: Wed, 17 Feb 2016 08:56:20 +0100	[thread overview]
Message-ID: <20160217085620.050d6132@free-electrons.com> (raw)
In-Reply-To: <56C3BC1E.1060002@mind.be>

Hello,

On Wed, 17 Feb 2016 01:17:34 +0100, Arnout Vandecappelle wrote:

>  I think the difference is in gcc versions. It looks like gcc 4.7 in that
> external toolchain uses a built-in inline version of __finite(), while gcc 4.9
> just calls the external function. I don't think it has anything to do with the
> uClibc version (though I didn't try all combinations). But for sure, it fails
> with gcc 4.9 and uClibc 1.0.10 while it succeeds with the same config and gcc 4.7.

Aaah, okay. Makes sense.

>  I don't think BR2_ENABLE_DEBUG has anything to do with it, but I didn't test that.
> 
>  Anyway, it seems obvious to me that if you use finite(), then you should link
> with -lm. There's bound to be some combination of libc and compiler that
> requires -lm.

I fully agree that from the beginning -lm is needed. However, I didn't
like the fact that the build failures were not fully understood.

> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-17  7:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 13:00 [Buildroot] [PATCH 1/1] package/iputils: patch ping to link against libm Martin Bark
2016-02-15 22:17 ` Thomas Petazzoni
2016-02-16 10:13   ` Martin Bark
2016-02-16 19:03   ` Waldemar Brodkorb
2016-02-16 19:58     ` Martin Bark
2016-02-16 20:30       ` Thomas Petazzoni
2016-02-16 20:28     ` Thomas Petazzoni
2016-02-17  0:17       ` Arnout Vandecappelle
2016-02-17  7:56         ` Thomas Petazzoni [this message]
2016-02-20 14:51 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217085620.050d6132@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.