From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alban Subject: Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call Date: Wed, 17 Feb 2016 13:40:30 +0100 Message-ID: <20160217134030.29e4c6d7@tock> References: <1455710300-30920-1-git-send-email-juhosg@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455710300-30920-1-git-send-email-juhosg@openwrt.org> Sender: stable-owner@vger.kernel.org To: Gabor Juhos Cc: Aban Bedel , Tejun Heo , linux-ide@vger.kernel.org, Ralf Baechle , Arnd Bergmann , stable@vger.kernel.org List-Id: linux-ide@vger.kernel.org On Wed, 17 Feb 2016 12:58:20 +0100 Gabor Juhos wrote: > The RB532 platform specific irq_to_gpio() implementation has been > removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of > custom gpio.h"). Now the platform uses the generic stub which causes > the following error: > > pata-rb532-cf pata-rb532-cf: no GPIO found for irq149 > pata-rb532-cf: probe of pata-rb532-cf failed with error -2 > > Drop the irq_to_gpio() call and get the GPIO number from platform > data instead. After this change, the driver works again: I think it would be preferable to move this driver to use the gpiod API. The changes needed should be about the same size and it would be a much more future proof fix. Alban From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2-g21.free.fr ([212.27.42.2]:61915 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422740AbcBQMkm (ORCPT ); Wed, 17 Feb 2016 07:40:42 -0500 Date: Wed, 17 Feb 2016 13:40:30 +0100 From: Alban To: Gabor Juhos Cc: Aban Bedel , Tejun Heo , linux-ide@vger.kernel.org, Ralf Baechle , Arnd Bergmann , Subject: Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call Message-ID: <20160217134030.29e4c6d7@tock> In-Reply-To: <1455710300-30920-1-git-send-email-juhosg@openwrt.org> References: <1455710300-30920-1-git-send-email-juhosg@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Wed, 17 Feb 2016 12:58:20 +0100 Gabor Juhos wrote: > The RB532 platform specific irq_to_gpio() implementation has been > removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of > custom gpio.h"). Now the platform uses the generic stub which causes > the following error: > > pata-rb532-cf pata-rb532-cf: no GPIO found for irq149 > pata-rb532-cf: probe of pata-rb532-cf failed with error -2 > > Drop the irq_to_gpio() call and get the GPIO number from platform > data instead. After this change, the driver works again: I think it would be preferable to move this driver to use the gpiod API. The changes needed should be about the same size and it would be a much more future proof fix. Alban