All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, Stephane Eranian <eranian@google.com>,
	Vikas Shivappa <vikas.shivappa@intel.com>
Subject: Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups
Date: Wed, 17 Feb 2016 16:28:10 +0000	[thread overview]
Message-ID: <20160217162810.GA2694@codeblueprint.co.uk> (raw)
In-Reply-To: <alpine.DEB.2.11.1602171706540.19512@nanos>

On Wed, 17 Feb, at 05:08:57PM, Thomas Gleixner wrote:
> On Wed, 17 Feb 2016, Thomas Gleixner wrote:
> 
> > CQM is a strict per package facility. Use the proper cpumasks to lookup the
> > readers.
> 
> Sorry for the noise. PEBKAC: quilt refresh missing. Correct version below.
> 
> Thanks,
> 
> 	tglx
> 
> 8<----------
> 
> Subject: x86/perf/cqm: Get rid of the silly for_each_cpu lookups
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Sun, 14 Feb 2016 23:09:06 +0100
> 
> CQM is a strict per package facility. Use the proper cpumasks to lookup the
> readers.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_cqm.c |   34 ++++++++++-------------------
>  1 file changed, 12 insertions(+), 22 deletions(-)

Right, I just could not make the connection between
topology_core_cpumask() and topology_physical_package_id() when I
wrote this code.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

  reply	other threads:[~2016-02-17 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 15:47 [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups Thomas Gleixner
2016-02-17 16:08 ` Thomas Gleixner
2016-02-17 16:28   ` Matt Fleming [this message]
2016-02-17 18:27   ` Vikas Shivappa
2016-02-17 18:31     ` Thomas Gleixner
2016-02-17 18:35       ` Thomas Gleixner
2016-02-17 18:48       ` Vikas Shivappa
2016-02-17 19:09         ` Thomas Gleixner
2016-02-18 20:15           ` Thomas Gleixner
2016-02-18 23:12             ` Vikas Shivappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217162810.GA2694@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vikas.shivappa@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.