From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON
Date: Wed, 17 Feb 2016 16:24:44 -0300 [thread overview]
Message-ID: <20160217192444.GB9909@kernel.org> (raw)
In-Reply-To: <20160217191535.GA5083@two.firstfloor.org>
Em Wed, Feb 17, 2016 at 08:15:35PM +0100, Andi Kleen escreveu:
> On Wed, Feb 17, 2016 at 03:56:21PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu:
> > > > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change.
> > > > It may be that in some other setups asm/bug.h is implicitely included.
> >
> > > Thanks, applying your fix, after making it build on acme/perf/core:
> >
> > I take that back, it is already there:
>
> Ok, but not in tip/perf/core. Can you push it there please?
Huh? I can't, this is not my tree, its Ingo's. But lemme check there...
[acme@jouet linux]$ git remote update tip
Fetching tip
remote: Counting objects: 13, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 13 (delta 11), reused 0 (delta 0)
Unpacking objects: 100% (13/13), done.
>From git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
5eaa0c926246..d7c926f699aa master -> tip/master
+ e2c90dd7e11e...65c23c65bee4 x86/efi -> tip/x86/efi (forced update)
605a46ee8353..8f8e2aec9944 x86/platform -> tip/x86/platform
[acme@jouet linux]$ git checkout -b aktest tip/perf/core
Branch aktest set up to track remote branch perf/core from tip.
Switched to a new branch 'aktest'
[acme@jouet linux]$ git blame tools/perf/builtin-stat.c | grep -w bug\.h
ba6039b6c8fcc tools/perf/builtin-stat.c (Jiri Olsa 2015-11-05 15:40:55 +0100 64) #include "asm/bug.h"
[acme@jouet linux]$ git remote -v | grep tip
tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (fetch)
tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (push)
[acme@jouet linux]$
next prev parent reply other threads:[~2016-02-17 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:39 [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Andi Kleen
2016-02-17 18:52 ` Arnaldo Carvalho de Melo
2016-02-17 18:56 ` Arnaldo Carvalho de Melo
2016-02-17 19:15 ` Andi Kleen
2016-02-17 19:24 ` Arnaldo Carvalho de Melo [this message]
2016-02-17 21:22 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217192444.GB9909@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.