From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: ross.zwisler@linux.intel.com, jack@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] xfs: fixes for XFS_DIFLAG2_DAX support
Date: Wed, 17 Feb 2016 15:04:54 -0500 [thread overview]
Message-ID: <20160217200454.GC4065@bfoster.bfoster> (raw)
In-Reply-To: <1455513734-15192-1-git-send-email-david@fromorbit.com>
On Mon, Feb 15, 2016 at 04:22:10PM +1100, Dave Chinner wrote:
> Hi folks,
>
> This is a series to add the correct constraints to using the on-disk
> inode flag to enable DAX on per-file basis. The same constraints are
> placed on setting the flag on directories for inheritance purposes.
>
> These constraints are:
> - the inode flag is limited to regular files or directory
> inodes.
> - the S_DAX flag is only ever set on regular files
> - the flag can only ever be set on filesystems which have
> blocksize == PAGE_SIZE (for now)
> - When the flag is set or cleared, the current mapping
> contents are flushed and then invalidated so that the new
> access mode starts with an empty mapping.
> - Setting or clearing the flag is atomic w.r.t. IO and
> page faults.
>
> I've tested these manually with xfs_io (patchset for supporting
> chattr +x/-x to be sent soon), and it all appears to work as
> expected. I'd like to push these for 4.5-rc6 so the initial kernel
> with support for this flag doesn't do silly things, so comments,
> testing and review woul dbe appreciated.
>
The commit log description for patch 3 (v2) looks like it needs to be
fixed up (multiple title lines and extraneous From: header), but
otherwise the series looks good to me:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> Cheers,
>
> Dave.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-17 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:22 [PATCH 0/4] xfs: fixes for XFS_DIFLAG2_DAX support Dave Chinner
2016-02-15 5:22 ` [PATCH 1/4] xfs: XFS_DIFLAG_DAX is only for regular files or directories Dave Chinner
2016-02-15 5:22 ` [PATCH 2/4] xfs: S_DAX is only for regular files Dave Chinner
2016-02-15 5:22 ` [PATCH 3/4] xfs: dynamically switch modes when XFS_DIFLAG2_DAX is set/cleared Dave Chinner
2016-02-17 7:31 ` [PATCH 3/4 v2] " Dave Chinner
2016-02-17 20:57 ` Ross Zwisler
2016-02-15 5:22 ` [PATCH 4/4] xfs: XFS_DIFLAG2_DAX limited by PAGE_SIZE Dave Chinner
2016-02-16 0:12 ` Eric Sandeen
2016-02-16 0:39 ` Dave Chinner
2016-02-16 0:54 ` Eric Sandeen
2016-02-16 23:53 ` [PATCH 0/4] xfs: fixes for XFS_DIFLAG2_DAX support Ross Zwisler
2016-02-17 0:23 ` Dave Chinner
2016-02-17 20:04 ` Brian Foster [this message]
2016-02-17 22:56 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217200454.GC4065@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=ross.zwisler@linux.intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.