From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965697AbcBQVWv (ORCPT ); Wed, 17 Feb 2016 16:22:51 -0500 Received: from one.firstfloor.org ([193.170.194.197]:42328 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965152AbcBQVWu (ORCPT ); Wed, 17 Feb 2016 16:22:50 -0500 Date: Wed, 17 Feb 2016 22:22:48 +0100 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Message-ID: <20160217212247.GC5083@two.firstfloor.org> References: <1455734348-13690-1-git-send-email-andi@firstfloor.org> <20160217185209.GA9299@kernel.org> <20160217185621.GA9909@kernel.org> <20160217191535.GA5083@two.firstfloor.org> <20160217192444.GB9909@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217192444.GB9909@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 04:24:44PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Feb 17, 2016 at 08:15:35PM +0100, Andi Kleen escreveu: > > On Wed, Feb 17, 2016 at 03:56:21PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu: > > > > > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change. > > > > > It may be that in some other setups asm/bug.h is implicitely included. > > > > > > > Thanks, applying your fix, after making it build on acme/perf/core: > > > > > > I take that back, it is already there: > > > > Ok, but not in tip/perf/core. Can you push it there please? > > Huh? I can't, this is not my tree, its Ingo's. But lemme check there... Never mind. Ended up being a local problem. Thanks for checking. -Andi