From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id v197si74682wmv.1.2016.02.18.00.51.07 for ; Thu, 18 Feb 2016 00:51:07 -0800 (PST) Date: Thu, 18 Feb 2016 09:51:06 +0100 From: Alexandre Belloni To: Krzysztof Kozlowski , Julia Lawall Cc: Valentin Rothberg , ldewangan@nvidia.com, kbuild-all@01.org, javier@osg.samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kbuild test robot Subject: [rtc-linux] Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Message-ID: <20160218085106.GP2189@piout.net> References: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> <56C57D1E.805@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <56C57D1E.805@samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 18/02/2016 at 17:13:18 +0900, Krzysztof Kozlowski wrote : > On 18.02.2016 17:06, Valentin Rothberg wrote: > > From: kbuild test robot > > > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > > threaded IRQs without a primary handler need to be requested with > > IRQF_ONESHOT, otherwise the request will fail. > > > > So pass the IRQF_ONESHOT flag in this case. > > > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > > > CC: Laxman Dewangan > > Signed-off-by: Fengguang Wu > > Signed-off-by: Valentin Rothberg > > --- > > drivers/rtc/rtc-max77686.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Nack, because: > 1. AFAIR this is a false positive. > 2. Was it tested? Was it reproduced? Was the bug actually spotted or > just coccicheck pointed this and you assumed that "request will fail"? > > Coccicheck is a great tool... but not necessarily for pointing run-time > bugs. > Definitively a false positive. Julia, I've been receiving quite a lot of those, is it possible to add a note that this generates false positives to try to stop people from blindly sending patches? I would have expected Valentin to know that though. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425632AbcBRIvL (ORCPT ); Thu, 18 Feb 2016 03:51:11 -0500 Received: from down.free-electrons.com ([37.187.137.238]:45934 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425227AbcBRIvI (ORCPT ); Thu, 18 Feb 2016 03:51:08 -0500 Date: Thu, 18 Feb 2016 09:51:06 +0100 From: Alexandre Belloni To: Krzysztof Kozlowski , Julia Lawall Cc: Valentin Rothberg , ldewangan@nvidia.com, kbuild-all@01.org, javier@osg.samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kbuild test robot Subject: Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Message-ID: <20160218085106.GP2189@piout.net> References: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> <56C57D1E.805@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C57D1E.805@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2016 at 17:13:18 +0900, Krzysztof Kozlowski wrote : > On 18.02.2016 17:06, Valentin Rothberg wrote: > > From: kbuild test robot > > > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > > threaded IRQs without a primary handler need to be requested with > > IRQF_ONESHOT, otherwise the request will fail. > > > > So pass the IRQF_ONESHOT flag in this case. > > > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > > > CC: Laxman Dewangan > > Signed-off-by: Fengguang Wu > > Signed-off-by: Valentin Rothberg > > --- > > drivers/rtc/rtc-max77686.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Nack, because: > 1. AFAIR this is a false positive. > 2. Was it tested? Was it reproduced? Was the bug actually spotted or > just coccicheck pointed this and you assumed that "request will fail"? > > Coccicheck is a great tool... but not necessarily for pointing run-time > bugs. > Definitively a false positive. Julia, I've been receiving quite a lot of those, is it possible to add a note that this generates false positives to try to stop people from blindly sending patches? I would have expected Valentin to know that though. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com