From: Jean Delvare <jdelvare@suse.de>
To: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: userptr support in drm drivers
Date: Thu, 18 Feb 2016 09:49:28 +0100 [thread overview]
Message-ID: <20160218094928.76e5fde2@endymion> (raw)
In-Reply-To: <56C387AF.6050305@amd.com>
Hi Christian,
On Tue, 16 Feb 2016 21:33:51 +0100, Christian König wrote:
> At least for Radeon and Amdgpu the current situation is actually what we
> want.
>
> > However I still find it confusing
> > that full userptr support is under #if defined(CONFIG_MMU_NOTIFIER),
> > and not under #if defined(CONFIG_RADEON_USERPTR), resp. #if
> > defined(CONFIG_AMDGPU_USERPTR). It means that full userptr support may
> > be included even if these options are disabled.
> Which is perfectly fine. Userptr support should be enabled when
> MMU_NOTIFIER is available.
>
> How this becomes available is a different story. You can explicitly
> enable it which then pulls in the MMU_NOTIFIER dependency or you just
> enable it when you have the notfier anyway because of some other dependency.
Again, how is this any better than just selecting MMU_NOTIFIER unconditionally?
The proliferation of kconfig options is not helping.
> That we have two options doing the same is just a matter of branching of
> amdgpu from radeon and not cleaning up the configuration options. So
> feel free to cleaning this up and write a patch which makes pulling in
> MMU_NOTIFIER as a general DRM option.
--
Jean Delvare
SUSE L3 Support
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-02-18 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 19:58 userptr support in drm drivers Jean Delvare
2016-02-16 20:33 ` Christian König
2016-02-16 21:14 ` Daniel Vetter
2016-02-18 8:59 ` Jean Delvare
2016-02-18 9:48 ` Christian König
2016-02-19 14:11 ` Jean Delvare
2016-02-19 14:58 ` Christian König
2016-02-29 15:35 ` Daniel Vetter
2016-02-18 8:49 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218094928.76e5fde2@endymion \
--to=jdelvare@suse.de \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.