From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946012AbcBRK3O (ORCPT ); Thu, 18 Feb 2016 05:29:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:52305 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425770AbcBRK3L (ORCPT ); Thu, 18 Feb 2016 05:29:11 -0500 Date: Thu, 18 Feb 2016 11:29:09 +0100 From: Borislav Petkov To: Ingo Molnar Cc: Peter Zijlstra , Tony Luck , linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Linus Torvalds , Andrew Morton Subject: Re: [PATCH v11 3/4] x86, mce: Add __mcsafe_copy() Message-ID: <20160218102909.GC3694@pd.tnic> References: <20160218082107.GA17851@gmail.com> <20160218095905.GC25010@twins.programming.kicks-ass.net> <20160218101942.GA9386@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160218101942.GA9386@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 11:19:42AM +0100, Ingo Molnar wrote: > > I think the whole notion of mcsafe here is 'wrong'. This copy variant simply > > reports the kind of trap that happened (#PF or #MC) and could arguably be > > extended to include more types if the hardware were to generate more. It is safe in the sense that when you get an MCE while shuffling data here, in the kernel, you don't die but you recover. Thus the exception handling games. So _safe() really sounds fitting here. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.