From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945958AbcBRKfz (ORCPT ); Thu, 18 Feb 2016 05:35:55 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:55300 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425384AbcBRKfx (ORCPT ); Thu, 18 Feb 2016 05:35:53 -0500 Date: Thu, 18 Feb 2016 11:35:46 +0100 From: Peter Zijlstra To: Ingo Molnar Cc: Tony Luck , linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , Linus Torvalds , Andrew Morton Subject: Re: [PATCH v11 3/4] x86, mce: Add __mcsafe_copy() Message-ID: <20160218103546.GS6357@twins.programming.kicks-ass.net> References: <20160218082107.GA17851@gmail.com> <20160218095905.GC25010@twins.programming.kicks-ass.net> <20160218101942.GA9386@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218101942.GA9386@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 11:19:42AM +0100, Ingo Molnar wrote: > > I think the whole notion of mcsafe here is 'wrong'. This copy variant simply > > reports the kind of trap that happened (#PF or #MC) and could arguably be > > extended to include more types if the hardware were to generate more. > > What would a better name be? memcpy_ret() or so? Yeah, uhmm.. naming. More options from the lack of inspiration department: memcpy_trap() memcpy_ex()