All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <dahi@linux.vnet.ibm.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
	bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com,
	pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs
Date: Thu, 18 Feb 2016 10:46:52 +0100	[thread overview]
Message-ID: <20160218104652.3cfd35ad@thinkpad-w530> (raw)
In-Reply-To: <20160218104113.23376c1f@nial.brq.redhat.com>


> >  #if !defined(CONFIG_USER_ONLY)
> > +void s390_hot_add_cpu(const int64_t id, Error **errp)
> > +{  
> to make it future-proof wrt migration it could be better to
> enforce here that 'id' grows in +1 steps so user
> won't be able create cpus with gaps.

That should be already covered by:

if (id != next_cpu_id)
...

or am I missing something?

David

  reply	other threads:[~2016-02-18  9:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 20:12 [Qemu-devel] [PATCH v4 0/5] Allow hotplug of s390 CPUs Matthew Rosato
2016-02-17 20:12 ` [Qemu-devel] [PATCH v4 1/5] s390x/cpu: Cleanup init in preparation for hotplug Matthew Rosato
2016-02-17 20:12 ` [Qemu-devel] [PATCH v4 2/5] s390x/cpu: Set initial CPU state in common routine Matthew Rosato
2016-02-17 20:12 ` [Qemu-devel] [PATCH v4 3/5] s390x/cpu: Move some CPU initialization into realize Matthew Rosato
2016-02-17 20:12 ` [Qemu-devel] [PATCH v4 4/5] s390x/cpu: Add functions to register CPU state Matthew Rosato
2016-02-18  8:57   ` David Hildenbrand
2016-02-18  9:36   ` Igor Mammedov
2016-02-18 20:22     ` Matthew Rosato
2016-02-17 20:12 ` [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs Matthew Rosato
2016-02-18  9:03   ` David Hildenbrand
2016-02-18  9:41   ` Igor Mammedov
2016-02-18  9:46     ` David Hildenbrand [this message]
2016-02-18 17:59       ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218104652.3cfd35ad@thinkpad-w530 \
    --to=dahi@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.