From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] efi: libstub: add strnlen() implementation
Date: Thu, 18 Feb 2016 13:33:37 +0000 [thread overview]
Message-ID: <20160218133337.GF2651@codeblueprint.co.uk> (raw)
In-Reply-To: <CAKv+Gu_bhat3RjoLDqUtUBG7bB0ECAdS1i4GF_AU9h=YfWz=tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 18 Feb, at 12:05:51PM, Ard Biesheuvel wrote:
> On 18 February 2016 at 12:04, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote:
> > On Tue, 16 Feb, at 04:29:19PM, Ard Biesheuvel wrote:
> >> Commit 91feabc2e224 ("scripts/dtc: Update to upstream commit
> >> b06e55c88b9b") introduces references to the strnlen() string function,
> >> which is not currently defined in the EFI stub. So add it to our string.c
> >>
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >> ---
> >> drivers/firmware/efi/libstub/string.c | 16 ++++++++++++++++
> >> 1 file changed, 16 insertions(+)
> >
> > Does this patch fix a build failure for ARM? Which tree is the above
> > commit in?
>
> It is in -next, and it will break the build once it hits upstream.
OK, could you resend and include the build failure in the commit log
and make a reference to fixing a build issue?
next prev parent reply other threads:[~2016-02-18 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 15:29 [PATCH] efi: libstub: add strnlen() implementation Ard Biesheuvel
[not found] ` <1455636559-7542-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-18 11:04 ` Matt Fleming
[not found] ` <20160218110446.GD2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 11:05 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_bhat3RjoLDqUtUBG7bB0ECAdS1i4GF_AU9h=YfWz=tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 13:33 ` Matt Fleming [this message]
[not found] ` <20160218133337.GF2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 14:01 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218133337.GF2651@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.