From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] spi: Use %u for unsigned int, %zu for size_t
Date: Thu, 18 Feb 2016 14:58:41 +0100 [thread overview]
Message-ID: <20160218135841.GA3941@ulmo.nvidia.com> (raw)
In-Reply-To: <20160218133619.GB7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Thu, Feb 18, 2016 at 01:36:19PM +0000, Mark Brown wrote:
> On Thu, Feb 18, 2016 at 02:32:57PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > When printing unsigned int it is more idiomatic to use %u, for size_t
> > the correct specifier is %zu (see Documentation/printk-formats.txt).
>
> These don't apply against current code, please check and resend. Fabio
> sent some similar patches the other day.
I started seeing this two days ago and didn't submit because I assumed
somebody else already had. When it didn't filter out on top of today's
-next I decided to send out.
I do see that Fabio's fixes went into your tree yesterday, possibly not
quite in time to make today's -next. Both his patches fix the same
warnings that mine did. The only thing missing seems to be the %i -> %u
conversion, but I don't think I'll respin just for that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: Use %u for unsigned int, %zu for size_t
Date: Thu, 18 Feb 2016 14:58:41 +0100 [thread overview]
Message-ID: <20160218135841.GA3941@ulmo.nvidia.com> (raw)
In-Reply-To: <20160218133619.GB7129@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Thu, Feb 18, 2016 at 01:36:19PM +0000, Mark Brown wrote:
> On Thu, Feb 18, 2016 at 02:32:57PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > When printing unsigned int it is more idiomatic to use %u, for size_t
> > the correct specifier is %zu (see Documentation/printk-formats.txt).
>
> These don't apply against current code, please check and resend. Fabio
> sent some similar patches the other day.
I started seeing this two days ago and didn't submit because I assumed
somebody else already had. When it didn't filter out on top of today's
-next I decided to send out.
I do see that Fabio's fixes went into your tree yesterday, possibly not
quite in time to make today's -next. Both his patches fix the same
warnings that mine did. The only thing missing seems to be the %i -> %u
conversion, but I don't think I'll respin just for that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-18 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 13:32 [PATCH 1/2] spi: Use %u for unsigned int, %zu for size_t Thierry Reding
2016-02-18 13:32 ` Thierry Reding
2016-02-18 13:32 ` [PATCH 2/2] spi: Prevent a type mismatch warning using min_t() Thierry Reding
2016-02-18 13:36 ` [PATCH 1/2] spi: Use %u for unsigned int, %zu for size_t Mark Brown
[not found] ` <20160218133619.GB7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-18 13:58 ` Thierry Reding [this message]
2016-02-18 13:58 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218135841.GA3941@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.