From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: libxl_device handling for nic and vtmp Date: Thu, 18 Feb 2016 17:54:38 +0100 Message-ID: <20160218165438.GA1394@aepfle.de> References: <20160218151321.GA10541@aepfle.de> <20160218155219.GA7186@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160218155219.GA7186@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Feb 18, Wei Liu wrote: > For example, user might not have specified mac address so the library > generates one for (s)he. You don't want mac address to regenerate after > save / restore or migration. But you don't want to preserve all > autogenerated state, so you use the original copy as template and fill > it up as you see fit. How does that fit into DEFINE_DEVICE_ADD? The functions do 1:1 copies, calling libxl__update_config_* looks unnecessary. Olaf