From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=yZlpe6aEN0DhZvWiq9gXmZQ7ZmIJVc42qUm08kwuQGM=; b=FHSOLicNl0igC+zb5sI54qUfsQkZo8Qanea75+5Un7nIE9ooIHQ1Dx8RRe7C4nkpbC YvjwCVIN/VqkZu0hNzu0GRwj2UjJO+l5rhw97THwPmi/V3J5rI+pg6zgkSmIPTMbvGks 0wcLHLa9k1ZKTexeK1pDUqhHEWcgWamGqaJ/Ka3YQiyA21Q2otPgNOWHIhqf8IJQWfWN UPRez5uW2tk5oN/aGHWUkZKhQ54B4MPqc6mVL8Uv9lmsmDqD2G4CslERhJZTLzOKo3LQ YwNLLkfSwFCLAskJnIVVWgHIq+9f46zK9eqsqqGgO35XhNQ40h2gIATAGElet1PB4qqQ 1YLw== Date: Thu, 18 Feb 2016 17:38:25 -0800 From: Stephen Hemminger Message-ID: <20160218173825.3dca8d27@xeon-e3> In-Reply-To: <20160218.153542.67284853154438064.davem@davemloft.net> References: <1455502026-23144-1-git-send-email-linus.luessing@c0d3.blue> <20160218.153542.67284853154438064.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH] net: fix bridge multicast packet checksum validation List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sgunderson@bigfoot.com, tom@herbertland.com On Thu, 18 Feb 2016 15:35:42 -0500 (EST) David Miller wrote: > From: Linus L=C3=BCssing > Date: Mon, 15 Feb 2016 03:07:06 +0100 >=20 > > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_= buff *skb, > > if (!pskb_may_pull(skb_chk, offset)) > > goto err; > > =20 > > - __skb_pull(skb_chk, offset); > > + ip_summed =3D skb->ip_summed; > > + csum_valid =3D skb->csum_valid; > > + csum_level =3D skb->csum_level; > > + csum_bad =3D skb->csum_bad; > > + csum =3D skb->csum; > > + > > + skb_pull_rcsum(skb_chk, offset); > > ret =3D skb_chkf(skb_chk); > > __skb_push(skb_chk, offset); > > =20 > > + skb->ip_summed =3D ip_summed; > > + skb->csum_valid =3D csum_valid; > > + skb->csum_level =3D csum_level; > > + skb->csum_bad =3D csum_bad; > > + skb->csum =3D csum; > > + >=20 > There really has to be a better way to fix this :-/ Agreed, this is gross. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948960AbcBSBiS (ORCPT ); Thu, 18 Feb 2016 20:38:18 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34355 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426654AbcBSBiQ convert rfc822-to-8bit (ORCPT ); Thu, 18 Feb 2016 20:38:16 -0500 Date: Thu, 18 Feb 2016 17:38:25 -0800 From: Stephen Hemminger To: David Miller Cc: linus.luessing@c0d3.blue, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sgunderson@bigfoot.com, noltari@gmail.com, tom@herbertland.com Subject: Re: [PATCH] net: fix bridge multicast packet checksum validation Message-ID: <20160218173825.3dca8d27@xeon-e3> In-Reply-To: <20160218.153542.67284853154438064.davem@davemloft.net> References: <1455502026-23144-1-git-send-email-linus.luessing@c0d3.blue> <20160218.153542.67284853154438064.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2016 15:35:42 -0500 (EST) David Miller wrote: > From: Linus Lüssing > Date: Mon, 15 Feb 2016 03:07:06 +0100 > > > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff *skb, > > if (!pskb_may_pull(skb_chk, offset)) > > goto err; > > > > - __skb_pull(skb_chk, offset); > > + ip_summed = skb->ip_summed; > > + csum_valid = skb->csum_valid; > > + csum_level = skb->csum_level; > > + csum_bad = skb->csum_bad; > > + csum = skb->csum; > > + > > + skb_pull_rcsum(skb_chk, offset); > > ret = skb_chkf(skb_chk); > > __skb_push(skb_chk, offset); > > > > + skb->ip_summed = ip_summed; > > + skb->csum_valid = csum_valid; > > + skb->csum_level = csum_level; > > + skb->csum_bad = csum_bad; > > + skb->csum = csum; > > + > > There really has to be a better way to fix this :-/ Agreed, this is gross. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net: fix bridge multicast packet checksum validation Date: Thu, 18 Feb 2016 17:38:25 -0800 Message-ID: <20160218173825.3dca8d27@xeon-e3> References: <1455502026-23144-1-git-send-email-linus.luessing@c0d3.blue> <20160218.153542.67284853154438064.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sgunderson@bigfoot.com, tom@herbertland.com To: David Miller Return-path: In-Reply-To: <20160218.153542.67284853154438064.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Thu, 18 Feb 2016 15:35:42 -0500 (EST) David Miller wrote: > From: Linus L=C3=BCssing > Date: Mon, 15 Feb 2016 03:07:06 +0100 >=20 > > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_= buff *skb, > > if (!pskb_may_pull(skb_chk, offset)) > > goto err; > > =20 > > - __skb_pull(skb_chk, offset); > > + ip_summed =3D skb->ip_summed; > > + csum_valid =3D skb->csum_valid; > > + csum_level =3D skb->csum_level; > > + csum_bad =3D skb->csum_bad; > > + csum =3D skb->csum; > > + > > + skb_pull_rcsum(skb_chk, offset); > > ret =3D skb_chkf(skb_chk); > > __skb_push(skb_chk, offset); > > =20 > > + skb->ip_summed =3D ip_summed; > > + skb->csum_valid =3D csum_valid; > > + skb->csum_level =3D csum_level; > > + skb->csum_bad =3D csum_bad; > > + skb->csum =3D csum; > > + >=20 > There really has to be a better way to fix this :-/ Agreed, this is gross.