From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
kernel-testers@vger.kernel.org, netdev@vger.kernel.org,
geert@linux-m68k.org, helmut.buchsbaum@gmail.com
Subject: Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO
Date: Fri, 19 Feb 2016 13:59:09 +0530 [thread overview]
Message-ID: <20160219082909.GA6312@sudip-pc> (raw)
In-Reply-To: <20160216.203606.1431228679408727525.davem@davemloft.net>
On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Date: Sat, 13 Feb 2016 19:33:15 +0530
>
> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> > with the error:
> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
> >
> > GPIO is now used to reset the switch so we should have a dependency on
> > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> > can build test it.
> >
> > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> > Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> >
> > v2: added COMPILE_TEST and gpio/consumer.h
>
> I'm going to apply Arnd's patch because it properly removes the
> unnecessary linux/gpio.h include.
I think Arnd's patch is still not applied as we are still having build
failures for the implicit declarations. Or you want me to send v3 after
removing unnecessary linux/gpio.h include?
regards
suduo
next prev parent reply other threads:[~2016-02-19 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 14:03 [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee
2016-02-13 14:03 ` Sudip Mukherjee
[not found] ` <1455372195-10825-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-17 1:36 ` David Miller
2016-02-17 1:36 ` David Miller
2016-02-19 8:29 ` Sudip Mukherjee [this message]
2016-02-19 16:13 ` David Miller
2016-02-19 16:13 ` David Miller
2016-02-19 16:35 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219082909.GA6312@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=helmut.buchsbaum@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.