From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
linux-i2c@vger.kernel.org, alexandra.yates@intel.com
Subject: Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
Date: Fri, 19 Feb 2016 10:39:17 +0200 [thread overview]
Message-ID: <20160219083917.GE1491@lahna.fi.intel.com> (raw)
In-Reply-To: <1455807273-133516-1-git-send-email-mika.westerberg@linux.intel.com>
On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote:
> Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add
> DNV PCI ID to the list of supported devices.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Wolfram,
Please do not yet apply this patch. It seems to have same PCI ID that
Alexandra (Cc'd) added to i2c-i801.c.
Alexandra, are you sure that the PCI ID you added for DNV is actually
compatible with i2c-i801.c?
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 7ba795b24e75..24c48e899a22 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -76,6 +76,7 @@
> #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59
> #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
> +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
>
> #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
> #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */
> @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
> { 0, }
> };
>
> --
> 2.7.0
next prev parent reply other threads:[~2016-02-19 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 14:54 [PATCH] i2c: ismt: Add Intel DNV PCI ID Mika Westerberg
2016-02-19 8:39 ` Mika Westerberg [this message]
2016-02-19 17:24 ` Yates, Alexandra
2016-03-03 21:15 ` Wolfram Sang
2016-03-04 8:38 ` Mika Westerberg
2016-02-19 20:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219083917.GE1491@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alexandra.yates@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=seth.heasley@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.