From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH V13 5/5] xl: add pvusb commands Date: Fri, 19 Feb 2016 13:07:08 +0100 Message-ID: <20160219120708.GA18695@gmail.com> References: <1453192795-15693-1-git-send-email-cyliu@suse.com> <1453192795-15693-6-git-send-email-cyliu@suse.com> <20160216165608.GA21669@gmail.com> <56C7626F02000066000AE505@relay2.provo.novell.com> <20160219105247.GA22789@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160219105247.GA22789@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com Cc: Juergen Gross , Jim Fehlig , Simon Cao , Chun Yan Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Feb 19, Olaf Hering wrote: > Not sure how to handle it, perhaps exit when xl -N is called? Also the interface is 'xl -N' is not clearly defined. What is it supposed to do with the newly introduced ctrl types? Should it display the json just for the dev, just for the ctrl+dev or the entire ctrl with all existing devs + the new dev? Who is the consumer of the json output? xl(1) says just "-N Dry run: do not actually execute the command." I'm asking this mainly in the context of main_vscsiattach, which right now dumps the enitre ctrl with all existing devs + the new dev. Olaf