From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm_crb: fix bad name pointer usage with struct resource Date: Fri, 19 Feb 2016 10:44:34 -0700 Message-ID: <20160219174434.GA15013@obsidianresearch.com> References: <1455668874-13261-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160217045219.GA26086@obsidianresearch.com> <20160217093623.GA9831@intel.com> <20160217142016.GA6951@intel.com> <20160218173140.GA5899@obsidianresearch.com> <20160219150606.GB7474@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160219150606.GB7474-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote: > Can you quickly check the two top-most patches: > > https://github.com/jsakkine/linux-tpmdd/commits/master Drop the change to crb_map_res, the memset is not needed. The shutdown change is probably OK for a rc fix, but it is still wrong. The shutdown has to be done inside the code after the core has removed all access to the tpm but before it has torn down so much that the driver doesn't work anymore. Jason ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948323AbcBSRon (ORCPT ); Fri, 19 Feb 2016 12:44:43 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:39180 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947811AbcBSRol (ORCPT ); Fri, 19 Feb 2016 12:44:41 -0500 Date: Fri, 19 Feb 2016 10:44:34 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource Message-ID: <20160219174434.GA15013@obsidianresearch.com> References: <1455668874-13261-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160217045219.GA26086@obsidianresearch.com> <20160217093623.GA9831@intel.com> <20160217142016.GA6951@intel.com> <20160218173140.GA5899@obsidianresearch.com> <20160219150606.GB7474@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160219150606.GB7474@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote: > Can you quickly check the two top-most patches: > > https://github.com/jsakkine/linux-tpmdd/commits/master Drop the change to crb_map_res, the memset is not needed. The shutdown change is probably OK for a rc fix, but it is still wrong. The shutdown has to be done inside the code after the core has removed all access to the tpm but before it has torn down so much that the driver doesn't work anymore. Jason