From: Tony Lindgren <tony@atomide.com>
To: Yong Li <sdliyong@gmail.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: allow DEBUG_UNCOMPRESS for OMAP2+
Date: Fri, 19 Feb 2016 10:02:38 -0800 [thread overview]
Message-ID: <20160219180237.GI21202@atomide.com> (raw)
In-Reply-To: <1451362159-27910-1-git-send-email-sdliyong@gmail.com>
Hi,
* Yong Li <sdliyong@gmail.com> [151228 20:12]:
> Based on the below
> commit ae3c99a26c60 ("ARM: 7806/1: allow DEBUG_UNCOMPRESS for Tegra"),
> change the .data section to .text section,
> to enable DEBUG_UNCOMPRESS for OMAP2+ platforms
> Tested okay using BeagleBone Black
Sorry for the delay, I just noticed this one while looking
through my inbox for pending patches.
I think we should first simplify things by moving things over
to use the generic DEBUG_UART_8250 code where the addresses
need to be specified in the .config. It's been on my list of
things to do for quite a while but I keep getting interrupted.
My guess is that if we do that, this patch is no longer
needed :) Yong, care to take a look at that?
Regards,
Tony
> Signed-off-by: Yong Li <sdliyong@gmail.com>
> ---
> arch/arm/Kconfig.debug | 2 +-
> arch/arm/include/debug/omap2plus.S | 13 ++++++++++---
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 259c0ca..e5ae36a 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1596,7 +1596,7 @@ config DEBUG_UART_8250_FLOW_CONTROL
> config DEBUG_UNCOMPRESS
> bool
> depends on ARCH_MULTIPLATFORM || PLAT_SAMSUNG || ARM_SINGLE_ARMV7M
> - default y if DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
> + default y if DEBUG_LL && (!DEBUG_OMAP2PLUS_UART || !ZBOOT_ROM) && \
> (!DEBUG_TEGRA_UART || !ZBOOT_ROM)
> help
> This option influences the normal decompressor output for
> diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
> index 6d867ae..12421f9 100644
> --- a/arch/arm/include/debug/omap2plus.S
> +++ b/arch/arm/include/debug/omap2plus.S
> @@ -58,11 +58,18 @@
>
> #define UART_OFFSET(addr) ((addr) & 0x00ffffff)
>
> +#if defined(ZIMAGE)
> + omap_uart_phys: .word 0
> + omap_uart_virt: .word 0
> + omap_uart_lsr: .word 0
> +#else
> +
> .pushsection .data
> -omap_uart_phys: .word 0
> -omap_uart_virt: .word 0
> -omap_uart_lsr: .word 0
> + omap_uart_phys: .word 0
> + omap_uart_virt: .word 0
> + omap_uart_lsr: .word 0
> .popsection
> +#endif
>
> .macro addruart, rp, rv, tmp
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: allow DEBUG_UNCOMPRESS for OMAP2+
Date: Fri, 19 Feb 2016 10:02:38 -0800 [thread overview]
Message-ID: <20160219180237.GI21202@atomide.com> (raw)
In-Reply-To: <1451362159-27910-1-git-send-email-sdliyong@gmail.com>
Hi,
* Yong Li <sdliyong@gmail.com> [151228 20:12]:
> Based on the below
> commit ae3c99a26c60 ("ARM: 7806/1: allow DEBUG_UNCOMPRESS for Tegra"),
> change the .data section to .text section,
> to enable DEBUG_UNCOMPRESS for OMAP2+ platforms
> Tested okay using BeagleBone Black
Sorry for the delay, I just noticed this one while looking
through my inbox for pending patches.
I think we should first simplify things by moving things over
to use the generic DEBUG_UART_8250 code where the addresses
need to be specified in the .config. It's been on my list of
things to do for quite a while but I keep getting interrupted.
My guess is that if we do that, this patch is no longer
needed :) Yong, care to take a look at that?
Regards,
Tony
> Signed-off-by: Yong Li <sdliyong@gmail.com>
> ---
> arch/arm/Kconfig.debug | 2 +-
> arch/arm/include/debug/omap2plus.S | 13 ++++++++++---
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 259c0ca..e5ae36a 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1596,7 +1596,7 @@ config DEBUG_UART_8250_FLOW_CONTROL
> config DEBUG_UNCOMPRESS
> bool
> depends on ARCH_MULTIPLATFORM || PLAT_SAMSUNG || ARM_SINGLE_ARMV7M
> - default y if DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
> + default y if DEBUG_LL && (!DEBUG_OMAP2PLUS_UART || !ZBOOT_ROM) && \
> (!DEBUG_TEGRA_UART || !ZBOOT_ROM)
> help
> This option influences the normal decompressor output for
> diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
> index 6d867ae..12421f9 100644
> --- a/arch/arm/include/debug/omap2plus.S
> +++ b/arch/arm/include/debug/omap2plus.S
> @@ -58,11 +58,18 @@
>
> #define UART_OFFSET(addr) ((addr) & 0x00ffffff)
>
> +#if defined(ZIMAGE)
> + omap_uart_phys: .word 0
> + omap_uart_virt: .word 0
> + omap_uart_lsr: .word 0
> +#else
> +
> .pushsection .data
> -omap_uart_phys: .word 0
> -omap_uart_virt: .word 0
> -omap_uart_lsr: .word 0
> + omap_uart_phys: .word 0
> + omap_uart_virt: .word 0
> + omap_uart_lsr: .word 0
> .popsection
> +#endif
>
> .macro addruart, rp, rv, tmp
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-19 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 4:09 [PATCH] ARM: OMAP2+: allow DEBUG_UNCOMPRESS for OMAP2+ Yong Li
2015-12-29 4:09 ` Yong Li
2016-02-19 18:02 ` Tony Lindgren [this message]
2016-02-19 18:02 ` Tony Lindgren
2016-02-21 12:19 ` LIYONG
2016-02-21 12:19 ` LIYONG
2016-02-21 12:19 ` LIYONG
2016-02-21 15:34 ` Tony Lindgren
2016-02-21 15:34 ` Tony Lindgren
2016-02-21 15:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219180237.GI21202@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sdliyong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.