From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428658AbcBSVDd (ORCPT ); Fri, 19 Feb 2016 16:03:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:39149 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427466AbcBSVDc (ORCPT ); Fri, 19 Feb 2016 16:03:32 -0500 Date: Fri, 19 Feb 2016 22:03:29 +0100 From: "Luis R. Rodriguez" To: Boris Ostrovsky Cc: "Luis R. Rodriguez" , hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, rusty@rustcorp.com.au, david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com, andriy.shevchenko@linux.intel.com, xen-devel@lists.xensource.com Subject: Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h Message-ID: <20160219210329.GT25240@wotan.suse.de> References: <1455891343-10016-1-git-send-email-mcgrof@kernel.org> <1455891343-10016-2-git-send-email-mcgrof@kernel.org> <56C73162.1040207@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C73162.1040207@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2016 at 10:14:42AM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote: > >diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h > >index 878e4b9940d9..232cff0ff4e3 100644 > >--- a/arch/x86/boot/bitops.h > >+++ b/arch/x86/boot/bitops.h > >@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr) > > asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr)); > > } > >+#define BIT(x) (1 << x) > > Parenthesize x. I'll just use (1UL << (nr)) then as well to match what include/linux/bitmap.h uses. Luis