All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sandhya <bankarsandhya512@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.
Date: Fri, 19 Feb 2016 13:24:27 -0800	[thread overview]
Message-ID: <20160219212427.GA3991@kroah.com> (raw)
In-Reply-To: <20160219120741.GA5755@sandhya>

On Fri, Feb 19, 2016 at 05:37:41PM +0530, Sandhya wrote:
> Add space before open parenthesis of "if" statement and fix indent warning.
> The checkpatch.pl script reported  error and warning.
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 2caaf5a..9a5c584 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
>  	custom.intreq = IF_RBF;
>  	mb();
>  
> -	if((serdatr & 0x1ff) == 0)
> -	    status |= UART_LSR_BI;
> -	if(serdatr & SDR_OVRUN)
> -	    status |= UART_LSR_OE;
> +	if ((serdatr & 0x1ff) == 0)
> +		status |= UART_LSR_BI;
> +	if (serdatr & SDR_OVRUN)
> +		status |= UART_LSR_OE;
>  
>  	ch = serdatr & 0xff;
>  	icount->rx++;
> 

We can't accept Outreachy application patches outside of the
drivers/staging/ portion of the kernel, sorry.

Also you forgot a signed-off-by: line, please go read the tutorial again
for all of the proper steps needed to create a patch.

thanks,

greg k-h


  reply	other threads:[~2016-02-19 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 12:07 [PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning Sandhya
2016-02-19 21:24 ` Greg KH [this message]
2016-02-20  3:49 ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219212427.GA3991@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bankarsandhya512@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.