Re: [Outreachy kernel] [PATCH] Staging: wilc1000: Remove unnecessary else after return

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Feb 19, 2016 at 03:18:25PM +0200, Dilek Uzulmez wrote:
> This patch fixes checkpatch.pl warning in files of wilc1000
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 544c12d..b0cefe1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -939,9 +939,9 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
>  	    gpstrWlanOps->wlan_cfg_get == NULL)	{
>  		PRINT_D(CORECONFIG_DBG, "Set and Get is still not initialized\n");
>  		return 1;
> -	} else {
> -		PRINT_D(CORECONFIG_DBG, "SET is initialized\n");
>  	}
> +		PRINT_D(CORECONFIG_DBG, "SET is initialized\n");
> +

Does that indentation look correct to you?  It doesn't to me...

thanks,

greg k-h