From: Stephen Hemminger <stephen@networkplumber.org>
To: <harish.patil@qlogic.com>
Cc: dev@dpdk.org, Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [PATCH 4/6] qede: add driver common module
Date: Sat, 20 Feb 2016 17:29:03 -0800 [thread overview]
Message-ID: <20160220172903.52db2811@xeon-e3> (raw)
In-Reply-To: <1455983911-17812-1-git-send-email-harish.patil@qlogic.com>
On Sat, 20 Feb 2016 07:58:31 -0800
<harish.patil@qlogic.com> wrote:
> +unsigned long log2_align(unsigned long n)
> +{
Common code is good, but you need to practice good function name
hygiene on public functions to avoid any namespace clashes when
using static linking.
The application might define a function with log2_align.
Either make the functions static, or use a common prefix for all qede
internal functions.
next prev parent reply other threads:[~2016-02-21 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 15:58 [PATCH 4/6] qede: add driver common module harish.patil
2016-02-21 1:29 ` Stephen Hemminger [this message]
2016-02-23 19:44 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160220172903.52db2811@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.