From: Greg KH <gregkh@linuxfoundation.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3] staging: lustre: llite: Remove IS_ERR tests
Date: Sat, 20 Feb 2016 14:38:28 -0800 [thread overview]
Message-ID: <20160220223828.GA29889@kroah.com> (raw)
In-Reply-To: <20160216120844.GA18950@amitoj-Inspiron-3542>
On Tue, Feb 16, 2016 at 05:38:44PM +0530, Amitoj Kaur Chawla wrote:
> ll_iget() has been modified to always return NULL in case of error and
> not a ERR_PTR.
>
> Consequently, remove unnecessary IS_ERR tests as now ll_iget() function
> can never return a ERR_PTR.
>
> This patch also removes checkpatch warnings:
> Comparison to NULL could be written "!root"
> Comparison to NULL could be written "!inode"
>
> Additionally, reinitialising root and inode to NULL has been removed
> since they have already been tested for the same.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v3:
> -Modified ll_iget() to only return NULL in case of error
> Changes in v2:
> -Remove IS_ERR test instead of replacing it with
> IS_ERR_OR_NULL
This doesn't apply to my staging-testing branch due to other changes in
these files by other developers that were send before your patch. Can
you please refresh your tree and rebase your patch and resend?
thanks,
greg k-h
prev parent reply other threads:[~2016-02-20 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 12:08 [PATCH v3] staging: lustre: llite: Remove IS_ERR tests Amitoj Kaur Chawla
2016-02-20 22:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160220223828.GA29889@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amitoj1606@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.