All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
	John Youn <johnyoun@synopsys.com>,
	Richard Weinberger <richard@nod.at>,
	James McMechan <James_McMechan@hotmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-usb@vger.kernel.org,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y
Date: Sat, 20 Feb 2016 20:23:34 -0800	[thread overview]
Message-ID: <20160221042334.GA14825@kroah.com> (raw)
In-Reply-To: <1455635459-1576-2-git-send-email-geert@linux-m68k.org>

On Tue, Feb 16, 2016 at 04:10:57PM +0100, Geert Uytterhoeven wrote:
> Some platforms don't have DMA, but we should still be able to build USB
> drivers for these platforms. They could still be used through vhci_hcd,
> usbip_host, or maybe something like USB passthrough in UML from a
> capable host.
> 
> If NO_DMA=y:
> 
>     ERROR: "dma_pool_destroy" [drivers/usb/core/usbcore.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/usb/core/usbcore.ko] undefined!
>     ERROR: "dma_pool_free" [drivers/usb/core/usbcore.ko] undefined!
>     ERROR: "dma_pool_alloc" [drivers/usb/core/usbcore.ko] undefined!
>     ERROR: "dma_pool_create" [drivers/usb/core/usbcore.ko] undefined!
> 
> Add a few checks for CONFIG_HAS_DMA to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
> v2:
>   - Replace remaining #ifdefs by IS_ENABLED() checks,
>   - Add to patch description that this actually allows using USB on UML,
>   - Add Acked-by.

This patch didn't apply to my tree, can you rebase it against usb-next
of usb.git and resend?

thanks,

greg k-h


  reply	other threads:[~2016-02-21  4:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 15:10 [PATCH v2 0/3] usb: Allow compilation on platforms where NO_DMA=y Geert Uytterhoeven
2016-02-16 15:10 ` [PATCH v2 1/3] usb: core: " Geert Uytterhoeven
2016-02-21  4:23   ` Greg Kroah-Hartman [this message]
2016-02-21 21:46     ` Geert Uytterhoeven
2016-02-22  3:09       ` Greg Kroah-Hartman
2016-02-16 15:10 ` [PATCH v2 2/3] usb: host: Host drivers relying on DMA should depend on HAS_DMA Geert Uytterhoeven
2016-02-16 15:10 ` [PATCH v2 3/3] usb: dwc2: USB_DWC2 " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221042334.GA14825@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=James_McMechan@hotmail.com \
    --cc=geert@linux-m68k.org \
    --cc=johnyoun@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=schwidefsky@de.ibm.com \
    --cc=stern@rowland.harvard.edu \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.