From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leon Romanovsky <leon@leon.nu>
Subject: Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller
Date: Sun, 21 Feb 2016 17:09:32 +0200
Message-ID: <20160221150932.GN30450@leon.nu>
References: <1455966006-13774-1-git-send-email-pandit.parav@gmail.com>
 <1455966006-13774-2-git-send-email-pandit.parav@gmail.com>
 <20160221074301.GK30450@leon.nu>
 <CAG53R5XGJESb+_-FtjLsK+jHoEmbePLd==G2knBMOcrfdPm62Q@mail.gmail.com>
 <20160221134518.GM30450@leon.nu>
 <CAG53R5U53sDQAURaWVeYmhnQSe+ncj+KWHdpOwbnrhE+OLVnMw@mail.gmail.com>
Reply-To: leon@leon.nu
Mime-Version: 1.0
Return-path: <linux-security-module-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=leon-nu.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:reply-to:mail-followup-to
         :references:mime-version:content-type:content-disposition
         :in-reply-to:user-agent;
        bh=GOIwS6ZuWxZ/vtXuM9VdrWWMXGft2VmEqtv6iTiuhJE=;
        b=fDD0IqvFPyqIuz/8vZ0Ljjrxlq54gWwT7EWVEJyoYD8Yr848ZOV/9ZLTxtk0SpP8Tm
         Xif2ptRpAL/P2ao7U1pa1EMWoPR6SYeMYFzA9bq6UEglVmBEljJ6BWQ2S7ZJbhqiHOeP
         gfiRv4fN4iHQabYkPdiu9kfSJ1Hrq/A7RWmOORxb3C9cnEbA0li3/qIxnUC8GlSJ48Ud
         EfaCAdpaUg2k4hh8sbtI1R16ocY91+l957aDL0nEVNrlGKoNBamvSQISumGfSXdPY5zE
         4gB6/85SpiYlLiZD7ocbWV3BqXWwumHLB8bg6zRPn6ALAdh9n3riCCpKsuFW2a9T7eu0
         L80g==
Content-Disposition: inline
In-Reply-To: <CAG53R5U53sDQAURaWVeYmhnQSe+ncj+KWHdpOwbnrhE+OLVnMw@mail.gmail.com>
Sender: owner-linux-security-module@vger.kernel.org
List-ID: <cgroups.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Parav Pandit <pandit.parav@gmail.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Tejun Heo <tj@kernel.org>, lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>, Doug Ledford <dledford@redhat.com>, Liran Liss <liranl@mellanox.com>, "Hefty, Sean" <sean.hefty@intel.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, Haggai Eran <haggaie@mellanox.com>, Jonathan Corbet <corbet@lwn.net>, james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz <ogerlitz@mellanox.com>, Matan Barak <matanb@mellanox.com>, raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org

On Sun, Feb 21, 2016 at 07:41:08PM +0530, Parav Pandit wrote:
> CONFIG_CGROUP_RDMA
> 
> On Sun, Feb 21, 2016 at 7:15 PM, Leon Romanovsky <leon@leon.nu> wrote:
> > On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote:
> >> On Sun, Feb 21, 2016 at 1:13 PM, Leon Romanovsky <leon@leon.nu> wrote:
> >> > On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote:
> >> > Can you place this ifdef before declaring struct rdma_cgroup?
> >> Yes. I missed out this cleanup. Done locally now.
> >
> > Great, additional thing which spotted my attention was related to
> > declaring and using the new cgroups functions. There are number of
> > places where you protected the calls by specific ifdefs in the
> > IB/core c-files and not in h-files as it is usually done.
> >
> ib_device_register_rdmacg, ib_device_unregister_rdmacg are the only
> two functions called from IB/core as its tied to functionality.
> They can also be implemented as NULL call when CONFIG_CGROUP_RDMA is undefined.
> (Similar to ib_rdmacg_try_charge and others).
> I didn't do because occurrence of call of register and unregister is
> limited to single file and only twice compare to charge/uncharge
> functions.
> Either way is fine with me, I can make the changes which you
> described. Let me know.

Please do,
IMHO, it is better to have one place which handles all relevant ifdefs
and functions. IB/core doesn't need to know about cgroups implementation.

Thanks