All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4: make sure to revoke all the freeable blocks in ext4_free_blocks
Date: Sun, 21 Feb 2016 18:35:21 -0500	[thread overview]
Message-ID: <20160221233521.GA23122@thunk.org> (raw)
In-Reply-To: <1450316940-10774-1-git-send-email-daeho.jeong@samsung.com>

On Thu, Dec 17, 2015 at 10:49:00AM +0900, Daeho Jeong wrote:
> Now, ext4_free_blocks() doesn't revoke data blocks of per-file data
> journalled inode and it can cause file data inconsistency problems.
> Even though data blocks of per-file data journalled inode are already
> forgotten by jbd2_journal_invalidatepage() in advance of invoking
> ext4_free_blocks(), we still need to revoke the data blocks here.
> Moreover some of the metadata blocks, which are not found by
> sb_find_get_block(), are still needed to be revoked, but this is also
> missing here.
> 
> Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.

Apologies for the delay.

						- Ted

  reply	other threads:[~2016-02-21 23:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  1:49 [PATCH v2] ext4: make sure to revoke all the freeable blocks in ext4_free_blocks Daeho Jeong
2016-02-21 23:35 ` Theodore Ts'o [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-17  2:42 Daeho Jeong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221233521.GA23122@thunk.org \
    --to=tytso@mit.edu \
    --cc=daeho.jeong@samsung.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.