From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnUt-0008TI-Tk for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:13:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXnUq-0002dg-73 for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:13:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnUq-0002dQ-1t for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:13:40 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 410383298 for ; Mon, 22 Feb 2016 10:13:39 +0000 (UTC) Date: Mon, 22 Feb 2016 10:13:35 +0000 From: "Daniel P. Berrange" Message-ID: <20160222101335.GB28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-2-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-2-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , Gerd Hoffmann , qemu-devel@nongnu.org, armbru@redhat.com On Fri, Feb 19, 2016 at 05:19:31PM -0700, Eric Blake wrote: > Commit d0d7708b forgot to parse logging for spice chardevs and > virtual consoles. This requires making qemu_chr_parse_common() > non-static. While at it, use a temporary variable to make the > code shorter, as well as reduce the churn when a later patch > alters the layout of simple unions. > > Signed-off-by: Eric Blake > CC: Daniel P. Berrange > --- > include/sysemu/char.h | 10 ++++++++++ > qemu-char.c | 2 +- > spice-qemu-char.c | 12 ++++++++---- > ui/console.c | 20 +++++++++++--------- > 4 files changed, 30 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|