From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnXO-0001KJ-0j for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:16:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXnXK-00037Z-8y for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:16:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnXK-00037Q-3F for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:16:14 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id CBD6418B319 for ; Mon, 22 Feb 2016 10:16:13 +0000 (UTC) Date: Mon, 22 Feb 2016 10:16:10 +0000 From: "Daniel P. Berrange" Message-ID: <20160222101610.GC28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-3-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-3-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , qemu-devel@nongnu.org, armbru@redhat.com On Fri, Feb 19, 2016 at 05:19:32PM -0700, Eric Blake wrote: > An upcoming patch will alter how simple unions, like ChardevBackend, > are laid out, which will impact all lines of the form 'backend->u.XXX'. > To minimize the impact of that patch, use a temporary variable to > reduce the number of lines needing modification when an internal > reference within ChardevBackend changes layout. > > Signed-off-by: Eric Blake > --- > qemu-char.c | 122 ++++++++++++++++++++++++++++++++---------------------------- > 1 file changed, 66 insertions(+), 56 deletions(-) Reviewed-By: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|