From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXna3-0002hT-Nn for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:19:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXna2-0003mI-M4 for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:19:03 -0500 Date: Mon, 22 Feb 2016 10:18:51 +0000 From: "Daniel P. Berrange" Message-ID: <20160222101851.GD28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-4-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-4-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 03/17] util: Shorten references into SocketAddress Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , "open list:Block layer core" , qemu-devel@nongnu.org, armbru@redhat.com, Gerd Hoffmann , Paolo Bonzini On Fri, Feb 19, 2016 at 05:19:33PM -0700, Eric Blake wrote: > An upcoming patch will alter how simple unions, like SocketAddress, > are laid out, which will impact all lines of the form 'addr->u.XXX'. > To minimize the impact of that patch, use C99 initialization or a > temporary variable to reduce the number of lines needing modification > when an internal reference within SocketAddress changes layout. > > Signed-off-by: Eric Blake > --- > block/nbd.c | 14 ++++++++------ > qemu-char.c | 43 ++++++++++++++++++++++++------------------ > qemu-nbd.c | 9 +++++---- > tests/test-io-channel-socket.c | 26 ++++++++++++++++--------- > ui/vnc.c | 39 +++++++++++++++++++------------------- > util/qemu-sockets.c | 11 ++++++----- > 6 files changed, 81 insertions(+), 61 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|