From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36969)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=K9lu=OV=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aXnbP-0004kd-06
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:20:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=K9lu=OV=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aXnbK-0004Dr-1N
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:20:26 -0500
Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:52426
	helo=sonata.ens-lyon.org) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from
	<SRS0=K9lu=OV=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aXnbJ-0004Cw-M8
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:20:21 -0500
Date: Mon, 22 Feb 2016 11:20:19 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160222102019.GT1957@var.home>
References: <cover.1455471945.git.samuel.thibault@ens-lyon.org>
	<e9b57bb9d1b749fe7858d42bce620e64e1046fa3.1455471945.git.samuel.thibault@ens-lyon.org>
	<56C71C5B.1040805@redhat.com> <20160222014848.GQ1957@var.home>
	<56CABF4B.5030002@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56CABF4B.5030002@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr
 structure with an union
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Hello,

Thomas Huth, on Mon 22 Feb 2016 08:56:59 +0100, wrote:
> would it maybe be applicable to use the
> TCPIPHDR_DELTA macro here instead?

No, because that includes a round up, while here we need an exact
difference.

Samuel