From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnpS-00043n-QV for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:34:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXnpR-0008HO-NG for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:34:58 -0500 Date: Mon, 22 Feb 2016 10:34:47 +0000 From: "Daniel P. Berrange" Message-ID: <20160222103447.GF28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-6-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-6-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/17] qapi: Avoid use of 'data' member of qapi unions Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Gerd Hoffmann , qemu-devel@nongnu.org, "open list:Block layer core" , armbru@redhat.com On Fri, Feb 19, 2016 at 05:19:35PM -0700, Eric Blake wrote: > qapi code generators currently create a 'void *data' member as > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of > the union feels a bit fishy, when we can directly use the rest > of the struct instead. > > Signed-off-by: Eric Blake > > --- > v1: no change > Previously posted as part of qapi cleanup series F: > v6: rebase to latest > --- > blockdev.c | 31 +++++++++++++++++-------------- > ui/input.c | 2 +- > 2 files changed, 18 insertions(+), 15 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|