From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnrR-0007pr-9k for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:37:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXnrN-00007q-Iv for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:37:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnrN-00007l-Df for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:36:57 -0500 Date: Mon, 22 Feb 2016 10:36:52 +0000 From: "Daniel P. Berrange" Message-ID: <20160222103652.GG28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-7-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-7-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/17] chardev: Drop useless ChardevDummy type Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Samuel Thibault , Paolo Bonzini , qemu-devel@nongnu.org, armbru@redhat.com On Fri, Feb 19, 2016 at 05:19:36PM -0700, Eric Blake wrote: > Commit d0d7708b made ChardevDummy be an empty wrapper type around > ChardevCommon. But there is no technical reason for this indirection, > so simplify the code by directly using the base type. > > Also change the fallback assignment to assign u.null rather than > u.data, since a future patch will remove the data member of the C > struct generated for QAPI unions. > > Signed-off-by: Eric Blake > --- > backends/baum.c | 2 +- > backends/msmouse.c | 2 +- > qemu-char.c | 6 +++--- > qapi-schema.json | 15 ++++++--------- > 4 files changed, 11 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|