From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXntV-0001su-Ga for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:39:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXntS-0000Pj-6y for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:39:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXntS-0000Pd-1J for qemu-devel@nongnu.org; Mon, 22 Feb 2016 05:39:06 -0500 Date: Mon, 22 Feb 2016 10:39:02 +0000 From: "Daniel P. Berrange" Message-ID: <20160222103901.GH28195@redhat.com> References: <1455927587-28033-1-git-send-email-eblake@redhat.com> <1455927587-28033-8-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455927587-28033-8-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , qemu-devel@nongnu.org, armbru@redhat.com On Fri, Feb 19, 2016 at 05:19:37PM -0700, Eric Blake wrote: > Now that we no longer have any clients of the 'void *data' > member injected into unions, we can drop it. Update the > testsuite to drop the negative test union-clash-data, and > replace it with a positive test in qapi-schema-test that > proves that we no longer have a name collision. > > Signed-off-by: Eric Blake > > --- > v1: drop patch that forced :empty as base to all structs > Previously posted as part of qapi cleanup subset F: > v6: rebase to earlier changes > --- > scripts/qapi-types.py | 9 --------- > tests/Makefile | 1 - > tests/qapi-schema/qapi-schema-test.json | 2 +- > tests/qapi-schema/qapi-schema-test.out | 4 ++-- > tests/qapi-schema/union-clash-data.err | 0 > tests/qapi-schema/union-clash-data.exit | 1 - > tests/qapi-schema/union-clash-data.json | 7 ------- > tests/qapi-schema/union-clash-data.out | 9 --------- > 8 files changed, 3 insertions(+), 30 deletions(-) > delete mode 100644 tests/qapi-schema/union-clash-data.err > delete mode 100644 tests/qapi-schema/union-clash-data.exit > delete mode 100644 tests/qapi-schema/union-clash-data.json > delete mode 100644 tests/qapi-schema/union-clash-data.out Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|