Re: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Feb 22, 2016 at 01:41:13PM +0900, Leo Kim wrote:
> This patch removes unnecessary wilc_debug print log.
> The print log was written when if condition fail.
> The condition is chip-id check function.
> Also, replaces this condition with normal function.
> 
> Signed-off-by: Leo Kim <leo.kim@atmel.com>
> ---
>  drivers/staging/wilc1000/wilc_wlan.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index f0ac47f..34018a1 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -502,9 +502,7 @@ void chip_wakeup(struct wilc *wilc)
>  
>  			do {
>  				usleep_range(2 * 1000, 2 * 1000);
> -				if ((wilc_get_chipid(wilc, true) == 0))
> -					wilc_debug(N_ERR, "Couldn't read chip id. Wake up failed\n");
> -
> +				wilc_get_chipid(wilc, true);

Remove this as well.  Don't leave random no-op function calls lying
around.

>  			} while ((wilc_get_chipid(wilc, true) == 0) && ((++trials % 3) == 0));
                                                                         ^^^^^^^^^^^^

This doesn't work as intended either.

regards,
dan carpenter