From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754656AbcBVLpc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Feb 2016 06:45:32 -0500
Received: from casper.infradead.org ([85.118.1.10]:46676 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754333AbcBVLpb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Feb 2016 06:45:31 -0500
Date: Mon, 22 Feb 2016 12:45:24 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Borislav Petkov <bp@alien8.de>, Stephane Eranian <eranian@google.com>,
        Harish Chegondi <harish.chegondi@intel.com>,
        Kan Liang <kan.liang@intel.com>, Andi Kleen <andi.kleen@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in
 event->pmu_private
Message-ID: <20160222114524.GA6357@twins.programming.kicks-ass.net>
References: <20160222110337.198341739@linutronix.de>
 <20160222110441.020475338@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160222110441.020475338@linutronix.de>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 22, 2016 at 11:06:50AM -0000, Thomas Gleixner wrote:
> Index: b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> ===================================================================
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> @@ -313,6 +313,7 @@ static int snb_uncore_imc_event_init(str
>  		return -EINVAL;
>  
>  	event->cpu = box->cpu;
> +	event->pmu_private = pmu;

This seems rather pointless, did you want that to be '= box' instead?

>  
>  	event->hw.idx = -1;
>  	event->hw.last_tag = ~0ULL;
> 
>