From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754852AbcBVL6b (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Feb 2016 06:58:31 -0500
Received: from casper.infradead.org ([85.118.1.10]:46991 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751137AbcBVL6a (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Feb 2016 06:58:30 -0500
Date: Mon, 22 Feb 2016 12:58:27 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Borislav Petkov <bp@alien8.de>, Stephane Eranian <eranian@google.com>,
        Harish Chegondi <harish.chegondi@intel.com>,
        Kan Liang <kan.liang@intel.com>, Andi Kleen <andi.kleen@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state
 on exit
Message-ID: <20160222115827.GC6357@twins.programming.kicks-ass.net>
References: <20160222110337.198341739@linutronix.de>
 <20160222110441.279798424@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160222110441.279798424@linutronix.de>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 22, 2016 at 11:06:52AM -0000, Thomas Gleixner wrote:
> +static void __init uncore_exit_boxes(void *dummy)
> +{
> +	struct intel_uncore_type **types = uncore_msr_uncores;
> +
> +	while (*types)
> +		__uncore_exit_boxes(*types++, smp_processor_id());

	for (types = uncore_msr_uncores; *types; types++)
		__uncore_exit_boxes(*types, smp_processor_id());

> +}

You flipped to for() loops in the other places, figures this one should
match?