From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aXp4f-0006F4-5Y
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 06:54:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aXp4a-0002W8-6Y
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 06:54:45 -0500
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:49788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aXp4Z-0002W1-Ry
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 06:54:40 -0500
Received: from localhost
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Mon, 22 Feb 2016 11:54:37 -0000
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id AEC23219005E
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 11:54:18 +0000 (GMT)
Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com
	[9.149.37.216])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u1MBsYdR34472056
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 11:54:34 GMT
Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u1MBsW5i025088
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 04:54:33 -0700
Date: Mon, 22 Feb 2016 12:54:29 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20160222125429.5532a334.cornelia.huck@de.ibm.com>
In-Reply-To: <1455831854-49013-2-git-send-email-silbe@linux.vnet.ibm.com>
References: <1455831854-49013-1-git-send-email-silbe@linux.vnet.ibm.com>
	<1455831854-49013-2-git-send-email-silbe@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message
 when alias device is unavailable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 18 Feb 2016 22:44:12 +0100
Sascha Silbe <silbe@linux.vnet.ibm.com> wrote:

> When trying to instantiate an alias that points to a device class that
> doesn't exist, the error message looks like qemu misunderstood the
> request:
> 
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid
> device model name
> 
> Special-case the error message to make it explicit that alias
> expansion is going on:
> 
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias
> 'virtio-gpu-ccw') is not a valid device model name
> 
> Suggested-By: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> ---
> v1->v2: new patch
> ---
>  qdev-monitor.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>